search

project-zot / zui

UI for zot registry
Apache License 2.0
13 stars 21 forks source link

[Bug]: UI/Vulnerabilities: Fixed-In section is not clear what it means, should not hide its content #393

Closed mikemccracken closed 7 months ago

mikemccracken commented 1 year ago

zot version

v1.4.3

Describe the bug

when viewing the list of vulns for a given image, there is a button "fixed in", which was not clear at first sight. It could be reworded to something like "Tags where this cve has been fixed:" or something even better.

Also, if feasible, this should not require a click to see if there are any such results. at a minimum it could say "tags where it's fixed (3):", or just display the list.

To reproduce

No response

Expected behavior

No response

Screenshots

image

Additional context

No response

andaaron commented 11 months ago

Some context.

"The fixed in" button makes a separate request to return results. That request will need the process the results for every image in the same repo.

If the results are cached, this should not be a big performance hit, but if they are not, that will involve a lot of work to be done on backend side to get information the user may not be interested in when accessing this tab.

mikemccracken commented 11 months ago

OK, that makes sense. I still think it'd be a nice improvement, but it isn't critical. If it's possible to display it inline when it's cached and just show a link when it's not, that'd be fine too. (assuming the cache lives for a while and someone else is likely to see it)

FWIW, from my perspective I would always be interested in this info when looking at the vulns for a tag.

I'd also still like to suggest changing the wording, or at least giving a help tooltip explaining it.

andaaron commented 7 months ago

Hi @mikemccracken, do we still need this change after the refactoring of the CVE tiles?

mikemccracken commented 7 months ago

Hi, no the new design resolves this. Thanks!