Closed raulkele closed 7 months ago
Attention: 127 lines
in your changes are missing coverage. Please review.
Comparison is base (
e037c6c
) 88.77% compared to head (3c38005
) 82.82%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The option to create API keys should depend on zot configuration, see this configuration option: https://github.com/project-zot/project-zot.github.io/pull/122/files#diff-af9facd062d9d27c91959f4f6adb3748a913491c414b4afc386e6925861e7263R107
I opened a PR to add this configuration to the results returned by the mgmt API, see https://github.com/project-zot/zot/pull/2138
Also, refresh doesn't seem to work on the API key page, I get 404 on refresh
The option to create API keys should depend on zot configuration, see this configuration option: https://github.com/project-zot/project-zot.github.io/pull/122/files#diff-af9facd062d9d27c91959f4f6adb3748a913491c414b4afc386e6925861e7263R107
I opened a PR to add this configuration to the results returned by the mgmt API, see project-zot/zot#2138
@raulkele the PR I mentioned has been merged, now you can check if the API Keys are enabled using the mgmt API, same as the other auth settings.
@andaaron updated the PR to match the api key config setting returned by the mgmt endpoint. The 404 issue seems to come from zot side. I opened a PR to fix it project-zot/zot#2141
Signed-off-by: Raul-Cristian Kele raulkeleblk@gmail.com
What type of PR is this? feature
Which issue does this PR fix: Closes #373
What does this PR do / Why do we need it: Implement api key management page Implement integration with the api key management backend feature
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.