feat(cve): add more information

project-zot / zui

UI for zot registry

Apache License 2.0

13 stars 21 forks source link

feat(cve): add more information #419

Closed Andreea-Lupu closed 9 months ago

Andreea-Lupu commented 9 months ago

What type of PR is this?

Which issue does this PR fix: https://github.com/project-zot/zui/issues/405 https://github.com/project-zot/zui/issues/394

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f4a6030) 88.60% compared to head (7aa0ad8) 88.77%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #419 +/- ## ========================================== + Coverage 88.60% 88.77% +0.17% ========================================== Files 56 56 Lines 1720 1720 Branches 451 463 +12 ========================================== + Hits 1524 1527 +3 + Misses 185 182 -3 Partials 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andaaron commented 9 months ago

The change looks good. I do have some suggestions for improvements:

Make the tiles/cards collapsed by default.
Only make the request to get the list of images which have the CVE fixed when someone expands the tile/card

What we have right now is functional and visibly and improvement for the user, but I have a concern with regards to how it will behave for a large number of images to be scanned.