Closed vrajashkr closed 8 months ago
I've kept the PR in Draft state temporarily as I'm seeing some local Unit Test failures which I'm not able to immediately figure out.
I've kept the PR in Draft state temporarily as I'm seeing some local Unit Test failures which I'm not able to immediately figure out.
Fixed! Missed to change the data testId :)
There was an additional suggestion regarding whether we'd like to hide this data in mobile view. Ref: https://github.com/project-zot/zui/pull/426#issuecomment-1961070897
Once we're all on the same page about whether to hide it, I can probably make that change in a separate PR.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.87%. Comparing base (
33524ce
) to head (8fa9abc
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @raulkele, gentle bump on this PR.
Would be great to get your feedback. Thanks!
Code looks good, only one small syntactic sugar suggestion. Now just looking for a final decision as to which version is preferred.
Like this better than PR #426
What type of PR is this? feature
Which issue does this PR fix: Towards https://github.com/project-zot/zot/issues/2175
What does this PR do / Why do we need it: This PR displays the Package Path information for the package list for a given CVE in the vulnerabilities list. Since there is more data being displayed, this PR also brings in a change to display this information in a vertically stacked form with a separate section for each affected package.
References #426
Testing done on this change: Screenshots:
CSV export:
XLSX export:
Will this break upgrades or downgrades. Has updating a running cluster been tested?: Ideally, this should not break upgrades or downgrades as the older graphQL query should continue working just fine as well as the updated query. No, updating a running cluster has not been tested.
Does this change require updates to the CNI daemonset config files to work?: N/A
Does this PR introduce any user-facing change?: Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.