search

project8 / dripline-python

python implementation of project8/dripline
Other
2 stars 0 forks source link

Merge feature for list-type endpoints #35

Closed laroque closed 5 years ago

laroque commented 5 years ago

enable list-type endpoints

laroque commented 5 years ago

Note, there was a corresponding bug in the calibrate method's assumption that things are strings, hot fixed above.

wcpettus commented 5 years ago

Looks good, although I'm confused that the files changed doesn't seem to show removal of this line and next: https://github.com/project8/dripline-python/blob/master/dripline/core/endpoint.py#L39

laroque commented 5 years ago

A note, I'm going to tag this 3.7.1 so that the two forks keep version numbers that agree (I'd already tagged 3.7 with the first half of this PR, then hot fixed the rest).