DBSCAN Noise Filter - Githubissues

project8 / katydid

Project 8 data analysis package

Other

5 stars 4 forks source link

DBSCAN Noise Filter #171

Closed nsoblath closed 5 years ago

nsoblath commented 5 years ago

Changes include:

New processor KTDBSCANNoiseFilter
Test program: TestDBSCANNoiseFiltering
New slot in KTSequentialTrackFinder: kd-tree
Cleanup of KTDBSCAN.hh
Updated nanoflann
Minor modifications to KTCreateKDTree
Added variance-histogram-writing slots to the Basic ROOT Writer
Added proc-track slot to the Basic ROOT Writer
Added slot kd-tree-scaled to the ROOT Tree Writer

cclaessens commented 5 years ago

You probably want to merge and release as fast as possible. I fixed the test executable name. I can build now and the test executables for testing the noise removal and the stf both work. The only things that remain unclear to me at the moment are whether you want to follow the codacy advice and whether the kdtree points power sorting doesn't mess with the time sorting. If you could address these questions I am happy with the pr and am approving it now because I need to go.

nsoblath commented 5 years ago

Regarding the Codacy issues, they're all in nanoflann, which isn't our code, so we can ignore it. I haven't figured out yet how to tell Codacy to ignore certain directories, so for now we'll just manually ignore those parts.

nsoblath commented 5 years ago

Ha, of course a quick search revealed the way to ignore files. Ok, so we should soon have an updated analysis from Codacy.