search

project8 / katydid

Project 8 data analysis package
Other
5 stars 4 forks source link

ChannelSummation feature branch #174

Closed psurukuc closed 5 years ago

psurukuc commented 5 years ago

Pull request to request for a quick review and comment on the naming/coding standards. Please let me know if the standards are being followed and I will change according to the comments. Warning: Not ready for merging into the 'develop' branch yet

pslocum commented 5 years ago

Thanks for committing this. To summarize, would you say that the present status is that the channel PSDs are summed, and that the next step is to write the new summed object to a root file? Also, a comment on this comment:
- "ps-ch": void (Nymph::KTDataPtr) -- Adds channels PSD now, will be moved to addition in frequencies; Requires KTPowerSpectrumData; Adds summation of the channel results; Emits signal "ps" We are summing the PSD across frequency now, and will keep doing that going forward. The next step will be to use fftw-phase while we are doing that.

psurukuc commented 5 years ago

Penny,

That is right. Currently, channel PSDs are summed and the next step is to write the new object to a root file.

About the comment, sorry, you are right, I will fix the comment.

Pranava

On Mon, Feb 11, 2019 at 12:36 PM Penny Slocum notifications@github.com wrote:

Thanks for committing this. To summarize, would you say that the present status is that the channel PSDs are summed, and that the next step is to write the new summed object to a root file? Also, a comment on this comment: - "ps-ch": void (Nymph::KTDataPtr) -- Adds channels PSD now, will be moved to addition in frequencies; Requires KTPowerSpectrumData; Adds summation of the channel results; Emits signal "ps" We are summing the PSD across frequency now, and will keep doing that going forward. The next step will be to use fftw-phase while we are doing that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/project8/katydid/pull/174#issuecomment-462420523, or mute the thread https://github.com/notifications/unsubscribe-auth/AHfQBPPVDHHl3JaTWHj8XqKQr7ocV2XRks5vMao2gaJpZM4ayrfz .