search

project8 / katydid

Project 8 data analysis package
Other
5 stars 4 forks source link

Feature/channel summation #187

Closed psurukuc closed 3 years ago

psurukuc commented 3 years ago

Not fully ready to merge. Need to confirm comments and such.

psurukuc commented 3 years ago

Andrew has been implementing his time-dependent grid in Katydid and that depends on some of the updates on this branch. Plan to merge this branch to develop and then push those changes into feature/time-domain-ch-sum branch before requesting a PR.

psurukuc commented 3 years ago

Hi Noah, thanks for very carefully going through the commits. I think I fixed all the suggestions expect for replacing YAML file with text file.

psurukuc commented 3 years ago

Actually, please hold off on reviewing. I think I may have to make a few more changes. Also, I realized I haven't actually pushed all my changes to github yet.

psurukuc commented 3 years ago

@nsoblath, thanks for the comments. I have implemented all the changes. There is a test program called TestChannelAggregator to test the ChannelAggregator and I modified it slightly to fit the new changes better.