search

project8 / katydid

Project 8 data analysis package
Other
5 stars 4 forks source link

Feature/replace fftw complex #191

Closed MCFlowMace closed 3 years ago

MCFlowMace commented 3 years ago

At the moment the optional Katydid_USE_EIGEN flag in the topmost CMakeLists.txt is just turned on by default. But can we make it optional still after the standard spectrum and timeseries objects now rely on it? What do you suggest to change other than switching the flag on by default? Or maybe the question is actually, how is a standard dependency handled differently?

psurukuc commented 3 years ago

Other than the ongoing disucssions about Eigen3 in CMakeLists, it all looks good to me.

nsoblath commented 3 years ago

@MCFlowMace is there a minimum Eigen version?

MCFlowMace commented 3 years ago

@MCFlowMace is there a minimum Eigen version?

I developed with version 3.3.9, might also work with earlier versions of course but that's untested.