project8 / psyllid

Data acquisition package for the ROACH2 system
Other
0 stars 1 forks source link

the frequency_transform node does not unpack the FFTW output array order #73

Closed laroque closed 6 years ago

laroque commented 6 years ago

this should be fixed by replacing line 191 of the .cc file with two such calls to keep things ordered correctly.

From Noah:

Source/Data/Transform/KTFrequencySpectrumFFTW.hh

    inline const fftw_complex& KTFrequencySpectrumFFTW::ReorderedBinAccess(unsigned i) const
    {
        return (i >= fCenterBin) ? fData[i - fCenterBin] : fData[i + fLeftOfCenterOffset];
    }

    inline fftw_complex& KTFrequencySpectrumFFTW::ReorderedBinAccess(unsigned i)
    {
        return (i >= fCenterBin) ? fData[i - fCenterBin] : fData[i + fLeftOfCenterOffset];
    }

where

fCenterBin(nBins/2)
laroque commented 6 years ago

interesting, resolves #73 works, but Noah wrote "fixes #73" which seems to not