ant-contrib should be included in the repo

projectEndings / staticSearch

A codebase to support a pure JSON search engine requiring no backend for any XHTML5 document collection

https://endings.uvic.ca/staticSearch/docs/index.html

Mozilla Public License 2.0

50 stars 22 forks source link

ant-contrib should be included in the repo #260

Closed joeytakeda closed 6 months ago

joeytakeda commented 1 year ago

Since ant-contrib is a simple JAR, we should include it in the repository rather than force end-users to install it separately.

peterrobinson commented 1 year ago

Cool idea. If you can. Check out what I had to do at https://scholarlydigitaleditions.blogspot.com/2023/07/staticsearch-and-me.html to get the right jars.

sydb commented 7 months ago

I am in favor of at least including ant-contrib in the repo, if not actually removing reliance on it. (Personally I really like ant-contrib, but I recognize that I like it out of laziness.)

A quick search says that ant-contrib is only used 5 times in the build files within the 1.4.5 release, all in the main build.xml file:

<if> is used 4 times (on lines 155,177, 194, and 307)
<propertyregex> is used once (on line 345)

joeytakeda commented 6 months ago

This should now be handled by PR #291 — adding ant-contrib to the staticSearch repo works and doesn't seem to conflict with having a local ant-contrib, so closing this.