search

projectEndings / staticSearch

A codebase to support a pure JSON search engine requiring no backend for any XHTML5 document collection
https://endings.uvic.ca/staticSearch/docs/index.html
Mozilla Public License 2.0
50 stars 22 forks source link

Fix overzealous removal of attributes for weight #288

Closed joeytakeda closed 7 months ago

joeytakeda commented 7 months ago

The switch from @data-(staticSearch|ss)-* to bare @ss- attributes was not reflected in the contextualization step, which means that weighting information was being totally ignored. This commit fixes this regression (but does not solve all of the issues with weighting and contextualization, which should be resolved in 2.0

This branch is based on release-1.4 so should only add a single commit; since the branches have diverged so significantly, I don't think it can be plucked from here to dev, so that will be a separate commit/PR

martindholmes commented 7 months ago

Added a specific test, and this seems to be working now. We might add more detailed tests later, especially in dev, but I'd like to get this into a release ASAP.