projectLEMDO / lemdoIssues

Repository for LEMDO issue tracking and related documents.
MIT License
1 stars 0 forks source link

DRE/NISE: padding before and after SDD on their own lines (modern text) #234

Closed JackWilton1594 closed 3 months ago

JackWilton1594 commented 3 months ago

SDD on their own line in the modern text should have padding before and after.

Some instances are rendered nicely; here, for example, from H5: Screen Shot 2024-06-06 at 15 49 10

But many others bunch too closely to the following line, as in these examples from 1HW: Screen Shot 2024-06-06 at 15 46 42 Screen Shot 2024-06-06 at 15 46 14

... and/or to the previous line, as in this example from H5: Screen Shot 2024-06-06 at 15 50 02

I think the amount of padding should be the same before/after.

JanelleJenstad commented 3 months ago

@LEMDO-PM: Further to our in-person discussion: if we are doing something different for entrances, let's not. Entrances should have the same padding before and after. There's no guarantee that the entrance has anything to do with the next speaker.

LEMDO-PM commented 3 months ago

@pszpak We want equal margin on either side of stage directions. We want to make sure that stage directions inside speeches are inline. In the HTML, the inline ones should all be <span data-el="stage"> elements that are children of either <div data-el="p"> or <div data-el="l"> (or descendants of <div data-el="sp">).

pszpak commented 3 months ago

Committed to lemdo-dev.scss:

/*Stage direction*/
span[data-el="stage"] {
  display: block;
}

:is([data-el="p"], [data-el="sp"])>span[data-el="stage"] {
  display: inline;
}
pszpak commented 3 months ago

I'm going to close this. Let me know if it needs to be reopened if the change is not satisfactory.