projectM-visualizer / frontend-sdl2

Standalone application based on SDL2 that turns your desktop audio into awesome visuals. Available on most platforms supported by both libprojectM and libSDL2.
GNU General Public License v3.0
58 stars 32 forks source link

V3.1.12 no windows build archive + V3.1.7 for windows 4k fullscreen bug #1

Closed roman80k closed 2 years ago

roman80k commented 2 years ago

Describe the bug

  1. There is no latest version build for Windows available
  2. Latest Windows build on 4k monitor fullscreen leaves visible space at the bottom, around 50-100px.
  3. Ctrl+F in this scenario crashes the application

Screenshots https://snipboard.io/vVophK.jpg

Additional context Scale in Windows settings is set to 200%, just in case

kblaschke commented 2 years ago

Even v3.1.12 is outdated, as since then, a lot of development work has happened. There were numerous bugs with fullscreen mode and the built-in menu which are fixed in the current source, but there is no new release yet as we switched to a new build system and the process isn't complete yet.

If you want to try out the current state of work, I'll be releasing a ready-to-use package made from the automated GitHub Actions builds from time to time, which you can find in my development fork of this repository:

https://github.com/kblaschke/projectm/releases

There you'll find a ZIP I've created a few days ago, including configuration instructions. Please give it a try and report if this fixed your above issues.

roman80k commented 2 years ago

Thanks man, I see.

Your version is fine: full screen is ok, so that issue is fixed.

But it seems to ignore settings file. I've copied it to %USERPROFILE%, I see it has been parsed - all comments were stripped down.

But anyway yes, 3.1.13 is much more stable.

kblaschke commented 2 years ago

Yes, the Fullscreen parameter is currently being ignored in the SDL frontend and hiding the cursor is also not working all the time.

Besides other improvements to this app, these things are on my long list of fixes before the actual 4.0 release. Really need to add a project with tasks here to keep track.

The configuration file stripping issue is tracked in issue projectM-visualizer/projectm#559, as it requires a lot of refactoring. The double-click feature to toggle fullscreen should be quite easy to implement and feel quite natural.

kblaschke commented 2 years ago

The rewritten app uses new code to switch between windows and fullscreen modes, and also can be configured to use either exclusive mode with resolution change, or a borderless window filling the whole screen.

There's no release yet of the new app, but this isn't considered a bug. the other issues noted in the last comment should also no longer be present in the new version, e.g. FPS limiting works and the mouse pointer is hidden in fullscreen mode and right-clicking switches between windows and fullscreen modes.

Closing this for now. If there are any issues or feature requests with the rewritten app here, please feel free to open a new issue.