search

projectM-visualizer / frontend-sdl2

Standalone application based on SDL2 that turns your desktop audio into awesome visuals. Available on most platforms supported by both libprojectM and libSDL2.
GNU General Public License v3.0
57 stars 32 forks source link

remove calls to projectm text helpers that are no longer available #44

Closed nzoschke closed 1 year ago

nzoschke commented 1 year ago

Replace calls to projectm text helpers removed in projectM-visualizer/projectm#652 with logging. Fixes #43

nzoschke commented 1 year ago

CC @kblaschke based on your comment on https://github.com/projectM-visualizer/projectm/pull/652

Also note this commit will break the rewritten SDL2 frontend for now, but that's fine. I'll fix that after the API changes are finished.

If you have a branch of frontend-sdl2 that addresses this I'm happy to review and work off that.

But I think it would be nice to get master / master building again to base other frontend improvements on.

kblaschke commented 1 year ago

I've not yet started to refactor the frontend, besauce there are plenty more API changes to come, e.g. moving the playlist functionality into another library with different API functions.

We can keep this PR open and keep it in sync to the ongoing changes in the main repo though, this will probably help some people to build the application against the latest upstream master. When the API changes are done, simply merge the PR and that's it.

nzoschke commented 1 year ago

Ok That works for me.

I'm able to maintain my own front end fork no problem for now.

Just sharing some of the pieces in case it helps others.

kblaschke commented 1 year ago

Opened another PR with a large number of other required changes, as libprojectM changed some more in the meantime.

Closing this PR, as the same change is also in the other one.