search

projectM-visualizer / projectm

projectM - Cross-platform Music Visualization Library. Open-source and Milkdrop-compatible.
https://discord.gg/mMrxAqaa3W
GNU Lesser General Public License v2.1
3.22k stars 364 forks source link

Add get and Set for beat sensitivity value to API #661

Closed kockie69 closed 1 year ago

kockie69 commented 1 year ago

In my battle to get the code change through it looks like previous PR disappeared. This version has been tested and linked correctly for me.

kblaschke commented 1 year ago

In my battle to get the code change through it looks like previous PR disappeared. This version has been tested and linked correctly for me.

I suggest using a working branch instead of working directly on master, this makes it easier to keep your fol up to date, rebase multiple working branches on the upstream changes etc., and it's probably the reason GitHub gets confused of you reset the master branch, leading to an autoclose of the PR.

There's two identical commits and an unnecessary merge commit here. Of you could manage to remove one of the duplicate commits and the merge commit, it's fine!

If you can't figure out how to clean the branch up, I can do that for you.

kockie69 commented 1 year ago

Can you have a look please and fix. Next time I will work from a separate branch.

kblaschke commented 1 year ago

Can you have a look please and fix. Next time I will work from a separate branch.

No need, it's perfect! Thanks for your contribution!