search

projectM-visualizer / projectm

projectM - Cross-platform Music Visualization Library. Open-source and Milkdrop-compatible.
https://discord.gg/mMrxAqaa3W
GNU Lesser General Public License v2.1
3.33k stars 372 forks source link

Fix unused variable warnings in release mode #703

Closed JohannesKauffmann closed 1 year ago

JohannesKauffmann commented 1 year ago

The assert()'s are removed in release mode causing unused variable warning noise.

JohannesKauffmann commented 1 year ago

Ah, I didn't know those two headers were going to go away soon. I'll remove those changes.

The warnings in the third party library seem to be caused by changes made by projectM to the fork (b03fb81711e3e3bd769a143ae10547f8eb2b01b8), so it seems only logical to fix them here in the fork as well. While it could be done with CMake, surely that's more complex than simple oneliner patch. You're going to end up fiddling with flags that work with one compiler but not another, etc. So for those two reasons I'd prefer the change proposed here.

kblaschke commented 1 year ago

No warnings are the best warnings! Merging.

JohannesKauffmann commented 1 year ago

Thanks!