search

projectM-visualizer / projectm

projectM - Cross-platform Music Visualization Library. Open-source and Milkdrop-compatible.
https://discord.gg/mMrxAqaa3W
GNU Lesser General Public License v2.1
3.32k stars 372 forks source link

Update config.guess to support riscv64 platform #715

Closed A1ca7raz closed 1 year ago

A1ca7raz commented 1 year ago

I am packaging this project for Arch Linux RISC-V and I noticed that config.guess script this projec use is too old to recognize riscv64 arch. This script should be updated to support riscv64 arch. To update this script manually while packaging, I ran this command before run configure script: autoreconf -fi && autoupdate -f then this problem should be fixed.

Describe the bug

Config.guess cannot recognize riscv64 architecture.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context

revmischa commented 1 year ago

It would be very cool to have it running on RISC-V! Please submit a PR if you know what needs to be fixed. I think you are maybe not using the latest version with CMake though? Please try building 4.0.0+ or master with CMake.

A1ca7raz commented 1 year ago

I found that the config.guess in the released 3.1.12 tarball is too old to recognize riscv32&riscv64 arch. Is it possible to repack v3.1.12?

revmischa commented 1 year ago

I found that the config.guess in the released 3.1.12 tarball is too old to recognize riscv32&riscv64 arch. Is it possible to repack v3.1.12?

There should be some way to do it with a local copy of a recent autoconf. But I would really suggest using cmake and the latest 4.x version instead.

kblaschke commented 1 year ago

I second Mischa's recommendation. Update packages to use the new 4.0 version and only provide these for previously unsupported architectures. Since projectM probably never worked there before, it might not break any existing applications, and since we've fixed tons of bugs, I don't see a good reason to ride a dead horse any further.

We'll also provide support to downstream developers as needed to update their integrations, and we expect 4.0 and newer versions of libprojectM to replace any 3.x version soon.

kblaschke commented 1 year ago

Closing the issue, as we're not going to re-release the old version. With CMake, please use a proper toolchain file if needed, otherwise I'd expect it to work without any additional changes.