serjykalstryke
commented
6 months ago I think some other things I changed that are unrelated got pushed up with the main change, feel free to ignore those.
Closed serjykalstryke closed 6 months ago
serjykalstryke
commented
6 months ago I think some other things I changed that are unrelated got pushed up with the main change, feel free to ignore those.
kblaschke
commented
6 months ago I think some other things I changed that are unrelated got pushed up with the main change, feel free to ignore those.
Looks like it. Can you update the PR/commit to only include the changes in pmSDL.hpp? You might also keep the .gitignore change if you wish as it seems to make sense for vcpkg users. Then I'll test-build and merge it.
Thanks for the contribution!
serjykalstryke
commented
6 months ago Will do that within the next 8 hours!
serjykalstryke
commented
6 months ago Alright, I think it is fixed.
I kept the changes to pmSDL.hpp and .gitignore (and also added some lines so that if someone wanted to have a nested repository for their personal fork of projectm, for better documenting projects built, etc., they could do this without it causing issues for the main project)
serjykalstryke
commented
6 months ago I closed this request, got everything fixed per your instructions and did a new request
I was having trouble building the entire project from the given code, and I was able to track down the issue with building the test UI project to the order the includes were in. It was calling windows libraries in an order that wasn't working with the newest SDK
Error I was encountering:
Severity Code Description Project File Line Suppression State Details Error C2065 'PKEY_NAME': undeclared identifier projectM-Test-UI C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\functiondiscoverykeys_devpkey.h 47
This error was repeated for every use of PKEY_NAME in that devkey.h file.
Again, changing the order of the includes fixes this issue.