search

projectM-visualizer / projectm

projectM - Cross-platform Music Visualization Library. Open-source and Milkdrop-compatible.
https://discord.gg/mMrxAqaa3W
GNU Lesser General Public License v2.1
3.22k stars 365 forks source link

Clean up minor warnings and code style #762

Closed dpw13 closed 5 months ago

dpw13 commented 5 months ago

This PR does modify some of the types in the C API, but in some functions keeps the types the same and performs a cast in the CWrapper file. If we need to maintain the exact function signatures for binary compatibility of libs, I will revert the signature changes. If changing the types is OK, I'll roll out the remaining changes to the signatures and remove the casts.

This removes nearly all of the warnings on Windows builds (outside of the vendor folder which still produces many warnings) and all warnings on Linux (which surprisingly does not emit warnings for the vendor folder files?).

While updating integer types in RandomNumberGenerators.cpp, I also attempted to clean up mismatching code styles and remove trailing whitespace.

kblaschke commented 5 months ago

Keeping binary compatibility is a must in the API, as 4.0 and 4.1 would otherwise not be compatible in either way, so please revert those changes. Everything that's happening in the C/C++ wrapper and beyond can be changed though.

Also, a few unit tests fail, which points to something not working the same as before.

dpw13 commented 5 months ago

Sounds good! I'll get on these changes tomorrow. I missed the C++14 compatibility and didn't test OSX builds, so I'll fix the unused parameter warnings some other way.

On Wed, Jan 31, 2024, 15:31 Kai Blaschke @.***> wrote:

Keeping binary compatibility is a must in the API, as 4.0 and 4.1 would otherwise not be compatible I either way, so please revert those changes. Everything that's happening in the C/C++ wrapper and beyond can be changed though.

Also, a few unit tests fail, which points to something not working the same as before.

— Reply to this email directly, view it on GitHub https://github.com/projectM-visualizer/projectm/pull/762#issuecomment-1920003448, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADD22CGGHTWF6CK5GUSL5TYRKZ2BAVCNFSM6AAAAABCTVEWTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQGAYDGNBUHA . You are receiving this because you authored the thread.Message ID: @.***>