search

projectM-visualizer / projectm

projectM - Cross-platform Music Visualization Library. Open-source and Milkdrop-compatible.
https://discord.gg/mMrxAqaa3W
GNU Lesser General Public License v2.1
3.22k stars 365 forks source link

Add VCPKG port #767

Closed Blaquewithaq closed 4 months ago

Blaquewithaq commented 4 months ago

This pull request introduces VCPKG packaging for the ProjectM library. This enhancement allows users to easily install the library through VCPKG, enabling its integration into CMake projects on the Windows platform.

Questions

Let me know what changes you guys want if any!

Blaquewithaq commented 4 months ago

Alright, I played around with it for a few hours and now got it working with PR's

kblaschke commented 4 months ago

I don't think that the vcpkg port files should be part of the library repository. Adding all the packaging system files for all Linux distros and other build systems would be a huge mess.

If there are changes required like the DLL install paths, this of course should be done here, but the actual port should be committed into the upstream vpkg repository instead. Once it's there, we can still run a build here to check that changes in the library didn't break the vcpkg port (or we actually have to update the port, if the breaking change is actually required).

Using libprojectm is a good choice IMO, as it makes it clear this is just the library.