Closed hoijui closed 6 years ago
Hi @hoijui , thanks for your contribution. I have only one suggesion for this PR: According to CONTRIBUTING.md, you need to
Ensure that each commit in the series has at least one Signed-off-by:line, using your real name and email address. The names in the Signed-off-by:andAuthor:lines must match. If anyone else contributes to the commit, they must also add their ownSigned-off-by:` line. By adding this line the contributor certifies the contribution is made under the terms of the Developer Certificate of Origin (DCO).
Please amend your commits via git commit --amend -s
and update the PR.
@Phillip-Wang ouh.. i nevr contributed to a project that has that.. cool, thanks! :-) I did it.
@hoijui , thanks again for your contribution.
two small commits that might help newcommers avoid two small issues