Decouple libvirt with acrnctl and support all acrnctl functionality on virsh (Phase 1)

[NanlinXie]

1. Decouple libvirt with acrnctl and support some acrnctl’s functionality on virsh
2. Enable guest auto-boot in ACRN libvirt

Acrnctl command	Libvirt functionality	Libvirt Features in ACRN v2.7
acrnctl add	define	Yes
acrnctl del	undefine	Yes
acrnctl list	list	Yes
acrnctl start	start	Yes
acrnd	autostart	Yes

[NanlinXie]

[External_System_ID] ACRN-6920

[NanlinXie]

Doc Impact Analysis:

• [ ] New feature -> new HLD and usage guide
  1. Refresh libvirt document
  2. Refine S5 doc
• [ ] HLDs add new module
• [ ] Configuration data
• [ ] Kernel module parameters
• [ ] Device Model (acrn-dm) parameters
• [ ] Hypervisor shell commands
• [ ] ACRN tools (debug and/or service) refine lifecyle mgr
• [ ] Build system
• [ ] Other documents (e.g. tutorials)

[gvancuts]

There are a few tutorials that reference acrnctl: "S5 enabling", "Kata Containers" and "OpenStack/libvirt"

Kata implementation also uses acrnctl so if we plan to deprecate or make the tool a debug tool like it was originally intended to be, we'll need to make adjustements to the Kata implementation and user guide.

[NanlinXie]

Postpone to v2.8

[dbkinder]

@NanlinXie Is this still a v2.8 target?

[NanlinXie]

We will not drop acrnctl in v2.8, thus there's no change for v2.8 document.

[NanlinXie]

GSG document need to be updated after this patch, we need add addtional library dependency at build time. sudo apt-get install libcjson-dev

[gvancuts]

I do not believe any documentation has been updated to reflect this change from acrnctl to virsh.

[fuzhongl]

@NanlinXie The linked JIRA is in Resolved status; Could you help to check if this task is done? Thanks!

[wuxyintel]

There are a few tutorials that reference acrnctl: "S5 enabling", "Kata Containers" and "OpenStack/libvirt", Kata implementation also uses acrnctl so if we plan to deprecate or make the tool a debug tool like it was originally intended to be, we'll need to make adjustments to the Kata implementation and user guide. @gvancuts please help double check my comments below, thanks! (1) In this phase, we only update libvirt to provide related virsh commands to implement acrnctl functionality. acrnctl functions still works. (2) For document "OpenStack/libvirt", I just remove acrnctl installation since libvirt doesn't depend on it. https://github.com/projectacrn/acrn-hypervisor/pull/7166 (3) For document "S5 enabling", current libvirt can't shutdown WaaG since user VM name is hard coded in the lifecycle manager of windows, I think we can update this after this bug is fixed. The related github issue will be created soon. (4) Kata is still use acrnctl, I think to another issue to track kata updates such as ("decouple kata with acrnctl"), BTW, kata can interact with the current DM directly now.

[gvancuts]

There are a few tutorials that reference acrnctl: "S5 enabling", "Kata Containers" and "OpenStack/libvirt", Kata implementation also uses acrnctl so if we plan to deprecate or make the tool a debug tool like it was originally intended to be, we'll need to make adjustments to the Kata implementation and user guide. @gvancuts please help double check my comments below, thanks! (1) In this phase, we only update libvirt to provide related virsh commands to implement acrnctl functionality. acrnctl functions still works. (2) For document "OpenStack/libvirt", I just remove acrnctl installation since libvirt doesn't depend on it. #7166 (3) For document "S5 enabling", current libvirt can't shutdown WaaG since user VM name is hard coded in the lifecycle manager of windows, I think we can update this after this bug is fixed. The related github issue will be created soon. (4) Kata is still use acrnctl, I think to another issue to track kata updates such as ("decouple kata with acrnctl"), BTW, kata can interact with the current DM directly now.

The list looks good to me. Can you tell me more about the Kata Containers status and ACRN. It used to use acrnctl to do the blkrescan operation and that was needed to run this. Have the changes for this landed yet?

Which version of virsh is used in our testing? Is that coming from the Ubuntu repo or it's built with the acrn-libvirt stuff?

[wuxyintel]

There are a few tutorials that reference acrnctl: "S5 enabling", "Kata Containers" and "OpenStack/libvirt", Kata implementation also uses acrnctl so if we plan to deprecate or make the tool a debug tool like it was originally intended to be, we'll need to make adjustments to the Kata implementation and user guide. @gvancuts please help double check my comments below, thanks! (1) In this phase, we only update libvirt to provide related virsh commands to implement acrnctl functionality. acrnctl functions still works. (2) For document "OpenStack/libvirt", I just remove acrnctl installation since libvirt doesn't depend on it. #7166 (3) For document "S5 enabling", current libvirt can't shutdown WaaG since user VM name is hard coded in the lifecycle manager of windows, I think we can update this after this bug is fixed. The related github issue will be created soon. (4) Kata is still use acrnctl, I think to another issue to track kata updates such as ("decouple kata with acrnctl"), BTW, kata can interact with the current DM directly now.

The list looks good to me. Can you tell me more about the Kata Containers status and ACRN. It used to use acrnctl to do the blkrescan operation and that was needed to run this. Have the changes for this landed yet?

I remember currently kata containers fails to run on ACRN, for old Kata code, it still use "acrnctl' to do "blkrescan". I think kata code will be refined to use command monitor to do "blkrescan" after v3.0.

Which version of virsh is used in our testing? Is that coming from the Ubuntu repo or it's built with the acrn-libvirt stuff?

The "virsh" tool should be built from "acrn-libvirt" for our testing, the version is 6.1.0.

[NanlinXie]

@gvancuts , could we close this issue now ?

[gvancuts]

@gvancuts , could we close this issue now ?

Not yet :-)

We need more documentation on what the tool does, how it's used, etc.

[gvancuts]

Hi @fuzhongl , this can be closed once the documentation is in place, I don't recall seeing it, have I missed it?