projectacrn / acrn-hypervisor

Project ACRN hypervisor
BSD 3-Clause "New" or "Revised" License
1.1k stars 506 forks source link

Clean up the board folder in acrn repo #6175

Open Kunhui-Li opened 3 years ago

Kunhui-Li commented 3 years ago

Currently we need clean up the board.xml

  1. Remove apl-up2, apl-up2-n3350, whl-ipc-i5, apl-mrb, nuc6cayh
  2. Update generic_board , copy from tgl-rvp
Kunhui-Li commented 3 years ago

[External_System_ID] ACRN-7200

NanlinXie commented 2 years ago

Closed since patch merged without regression.

NanlinXie commented 2 years ago

Reopen for document update.

NanlinXie commented 2 years ago

We need check whether any document linked to these removed boards: apl-up2, apl-up2-n3350, whl-ipc-i5, apl-mrb, nuc6cayh

gvancuts commented 2 years ago

There are still some references left in those docs:

$ grep apl- * -r
doc/tutorials/create-up2-images.sh:        ACRN_SBL=sos_rootfs/usr/lib/acrn/acrn.apl-up2.sbl.sdc.32.out
doc/tutorials/create-up2-images.sh:        make -C ${ACRN_HV_CODE_PATH} hypervisor BOARD=apl-up2 FIRMWARE=sbl || return 1
misc/config_tools/xforms/lib.xsl:      <!-- apl-mrb hidden devices list: [00:0d:0] -->
misc/config_tools/xforms/lib.xsl:      <xsl:when test="//@board = 'apl-mrb'">
misc/config_tools/xforms/lib.xsl:      <!-- apl-up2 hidden devices list: [00:0d:0] -->
misc/config_tools/xforms/lib.xsl:      <xsl:when test="//@board = 'apl-up2'">
misc/config_tools/library/board_cfg_lib.py:    'apl-mrb':['00:0d:0'],
misc/config_tools/library/board_cfg_lib.py:    'apl-up2':['00:0d:0'],
misc/config_tools/board_inspector/README:board_name : the name of board that run ACRN hypervisor, like apl-up2/nuc7i7dnb. It will be used as name of the board configurations folder which created by acrn-config host tool.
gvancuts commented 2 years ago

There are still some references left in those docs:

$ grep apl- * -r
doc/tutorials/create-up2-images.sh:        ACRN_SBL=sos_rootfs/usr/lib/acrn/acrn.apl-up2.sbl.sdc.32.out
doc/tutorials/create-up2-images.sh:        make -C ${ACRN_HV_CODE_PATH} hypervisor BOARD=apl-up2 FIRMWARE=sbl || return 1
misc/config_tools/xforms/lib.xsl:      <!-- apl-mrb hidden devices list: [00:0d:0] -->
misc/config_tools/xforms/lib.xsl:      <xsl:when test="//@board = 'apl-mrb'">
misc/config_tools/xforms/lib.xsl:      <!-- apl-up2 hidden devices list: [00:0d:0] -->
misc/config_tools/xforms/lib.xsl:      <xsl:when test="//@board = 'apl-up2'">
misc/config_tools/library/board_cfg_lib.py:    'apl-mrb':['00:0d:0'],
misc/config_tools/library/board_cfg_lib.py:    'apl-up2':['00:0d:0'],
misc/config_tools/board_inspector/README:board_name : the name of board that run ACRN hypervisor, like apl-up2/nuc7i7dnb. It will be used as name of the board configurations folder which created by acrn-config host tool.

All still there...

gvancuts commented 1 year ago

We still have references to APL left in our repo, is there any reason we cannot clean those?

$ grep apl- * -r
doc/tutorials/create-up2-images.sh:        ACRN_SBL=sos_rootfs/usr/lib/acrn/acrn.apl-up2.sbl.sdc.32.out
doc/tutorials/create-up2-images.sh:        make -C ${ACRN_HV_CODE_PATH} hypervisor BOARD=apl-up2 FIRMWARE=sbl || return 1
misc/config_tools/xforms/lib.xsl:      <!-- apl-mrb hidden devices list: [00:0d:0] -->
misc/config_tools/xforms/lib.xsl:      <xsl:when test="//@board = 'apl-mrb'">
misc/config_tools/xforms/lib.xsl:      <!-- apl-up2 hidden devices list: [00:0d:0] -->
misc/config_tools/xforms/lib.xsl:      <xsl:when test="//@board = 'apl-up2'">
misc/config_tools/library/board_cfg_lib.py:    'apl-mrb':['00:0d:0'],
misc/config_tools/library/board_cfg_lib.py:    'apl-up2':['00:0d:0'],
misc/config_tools/data/sample_launch_scripts/apl-mrb/launch_uos.sh:config_src="/usr/share/acrn/samples/apl-mrb/runC.json"
misc/config_tools/board_inspector/README:board_name : the name of board that run ACRN hypervisor, like apl-up2/nuc7i7dnb. It will be used as name of the board configurations folder which created by acrn-config host tool.
fuzhongl commented 1 year ago

The linked JIRA: 7200 is closed. @NanlinXie Any further action?