search

projectatomic / adb-tests

placeholder for tests for the adb while its long term place to live is sorted out
GNU General Public License v2.0
7 stars 19 forks source link

vagrant sanity case #35

Closed pavanbhat21 closed 8 years ago

amitkrout commented 8 years ago

@pavanbhat21 please add doc string specific to the function. Add readme file to it regarding how to use it.

optak commented 8 years ago

Please remove changes to config file which are not usable for other users. I recommend to use your own local config for these settings.

optak commented 8 years ago

Wouldn't be better to expect credentials for registration plugin in env variables as recommended by doc, than using expect to respond to input? vagrant_BOX_PATH Is for *.box file, it doesn't make sence to chdir to it, use vagrant_VAGRANTFILE_DIR instead

pavanbhat21 commented 8 years ago

Doc string added. Removed variables from the config file. Changes the box path to vagrant_VAGRANTFILE_DIR and have removed pexpect and vagrant up with subscription is now performed by setting env variables.

optak commented 8 years ago

Thanks Pavan for answers. As you explained to me, using method for vagrant up is necessary because of pexpect. Let's move these vagrant_up* methods to library in separate PR. It's very useful and I expect it to be used in almost every test, so please consider shorter names.