We should not expose docker registry and image name for OCP in CDK

projectatomic / adb-utils

A set of utilities for managing services used provided in the Atomic Developer Bundle.

GNU General Public License v2.0

13 stars 22 forks source link

We should not expose docker registry and image name for OCP in CDK #188

Open LalatenduMohanty opened 7 years ago

LalatenduMohanty commented 7 years ago

We should not expose docker registry and image name for OCP in CDK in the rhel-ose Vagrantfile as these are constant for CDK.

example (at present):

DOCKER_REGISTRY="registry.access.redhat.com"
IMAGE_NAME="openshift3/ose"
IMAGE_TAG="v3.3.0.32"

IMO it should be just the image tag which will help users to change if they want to go to another version. For example the Vagrrantfile should only contain

IMAGE_TAG="v3.3.0.32"

LalatenduMohanty commented 7 years ago

@praveenkumar @budhrg @hferentschik comments?

praveenkumar commented 7 years ago

@LalatenduMohanty Agree, please check follow https://github.com/projectatomic/adb-utils/issues/190 also.