search

projectatomic / adb-utils

A set of utilities for managing services used provided in the Atomic Developer Bundle.
GNU General Public License v2.0
13 stars 22 forks source link

Should drop eap64 since the examples for it seem deprecated #215

Open adietish opened 7 years ago

adietish commented 7 years ago

Our eap64-* templates are using the 6.4.x branch of the quickstarts at https://github.com/jboss-developer/jboss-eap-quickstarts When trying to improve these (the quickstarts to compil require a user to update his settings.xml, which is imho far from ideal), I was told that this branch is not maintained any more. They say 7.1.x is the current branch: https://github.com/jboss-developer/jboss-eap-quickstarts/issues/2062#issuecomment-275407243 I therefore suggest that we drop the 6.4.x examples (and all together eap64?) and switch to the 7.1.x (and use eap71?).

praveenkumar commented 7 years ago

@adietish https://github.com/jboss-openshift/application-templates/raw/master/eap/eap64-basic-s2i.json is what we sync with adb-utils as part of template after https://github.com/projectatomic/adb-utils/issues/87 . We are not aware if that is not maintained/updated any more if that is the case then we need change our Makefile to fetch a valid template.

adietish commented 7 years ago

@praveenkumar to my understanding - and i asked explicitly - the 6.4.x examples are deprecated (https://github.com/jboss-developer/jboss-eap-quickstarts/issues/2062#issuecomment-276172175). The issue that exists with these is that they wont compile out of the box. They're lacking a maven repository which offers required dependencies. This issue was fixed in 7.0.0.GA. I therefore suggest that the eap-64 templates (which are using these) get dropped. Agree?

adietish commented 6 years ago

@praveenkumar latest CDK 3.2 is apparently still using the eap-64 templates. Is there are reason for it (given that they're considered deprecated and wont compile out-of-the-box) or do I miss something?

adietish commented 6 years ago

@praveenkumar any updates on this please?

adietish commented 6 years ago

@praveenkumar any updates on this please?

LalatenduMohanty commented 6 years ago

@adietish I think we agreed that CDK can not do much here as it is an upstream EAP issue. May be we should discuss this again.

adietish commented 6 years ago

@LalatenduMohanty thx for the feedback! Offering EAP templates that don't work out of the box taints the user experience. Something we really should fix IMHO. Can you please make this happen?

praveenkumar commented 6 years ago

@adietish https://github.com/openshift/openshift-ansible/tree/master/roles/openshift_examples/files/examples/v3.7 where we are fetching templates and https://github.com/minishift/minishift/blob/master/addons/xpaas/xpaas.addon this is something we have which create template do you think we should remove https://github.com/minishift/minishift/blob/master/addons/xpaas/xpaas.addon#L30-L40 and that works for you or there is changes need from images stream side also?

adietish commented 6 years ago

@praveenkumar ok to remove the templates that you were pointing at. Looking at the image streams I bet the following should get removed, too: https://github.com/minishift/minishift/blob/master/addons/xpaas/xpaas-streams/jboss-image-streams.json#L174

LalatenduMohanty commented 6 years ago

@adietish @praveenkumar It seems EAP 6 is supported till Jun 2025 [1] . We should document the issue and the workaround for EAP6.4 in the documentation and will push EAP team to release another template with the fix. Once we have the new EAP 6 template with the fix then we can remove the old one.

[1] https://access.redhat.com/support/policy/updates/jboss_notes

RickJWagner commented 6 years ago

A note for future reference, in case questions arise. Fuse 6.3 is currently provided on OpenShift via 'FIS'. Fuse/Karaf and Fuse/Spring Boot are offered, Fuse/EAP is not.
Fuse/EAP is currently offered only on bare metal, based on EAP 6.4.
Fuse 7 (due out next year) is supposed to offer Fuse/EAP based on EAP 7.x.

Conclusion: Dropping EAP 6.4 templates will not affect current Fuse/EAP offerings on OpenShift, as none exist. If something changes (i.e. a delay in the Fuse 7 schedule prompts a change to what's offered in FIS for Fuse 6.3) that might change. This seems quite unlikely, though.

LalatenduMohanty commented 6 years ago

Thanks @RickJWagner for the information. @Bob-Davis also gave us similar information. So we are going to remove it. Created issue https://github.com/minishift/minishift/issues/2073