Open miabbott opened 7 years ago
As part of this work, we should try to structure the roles
directory using sub-dirs that correspond to major pieces of functionality. For example:
roles/
├── atomic
│ ├── containers
│ ├── images
│ ├── install
│ ├── run
│ └── tasks
├── docker
│ ├── build
│ ├── rm
│ ├── rmi
│ ├── run
│ └── tasks
├── ostree
│ ├── admin
│ ├── log
│ ├── pull
│ ├── remote
│ └── tasks
└── rpm-ostree
├── compose
├── deploy
├── install
├── tasks
└── upgrade
There could be even more sub-dirs under each one of those, too.
I was stepping (via
--step
) through theimproved-sanity-tests
and examining the test itself by hand and realized that we have more than a few instances of duplication in ourroles
directory.We should attempt to identify roles that can be combined and made more flexible via passed in parameters.
Things that jump right out:
docker_build_httpd
&docker_build_tag_push
docker_pull_base_image
&docker_pull_run_remove
docker_rm_httpd_conainer
could be generalized