Ensure all role variables are prefixed

projectatomic / atomic-host-tests

A collection of single-host tests for Atomic Host

GNU General Public License v3.0

18 stars 21 forks source link

Ensure all role variables are prefixed #376

Closed mike-nguyen closed 6 years ago

mike-nguyen commented 6 years ago

The role variables should be prefixed and adhere to the openshift style guide [0]. Most of the roles already do this but I noticed some that don't. I've run into issues using include_role where there are variable collisions that were resolved when using prefixed variable names.

[0] https://github.com/openshift/openshift-ansible/blob/master/docs/style_guide.adoc#Role-variables-MUST-have-a-prefix-of-atleast-3-characters-See.below.for.specific.naming.rules

miabbott commented 6 years ago

This looks like #224

We should close one of these; I don't really care which one...

mike-nguyen commented 6 years ago

I'll close this one in favor of #224