projectatomic / atomic-host-tests

A collection of single-host tests for Atomic Host
GNU General Public License v3.0
18 stars 21 forks source link

introduce podman sanity checks #417

Closed miabbott closed 6 years ago

miabbott commented 6 years ago

podman is included in most (all?) of the AH streams that we are testing, so let's start making sure it works on Atomic Host.

This is a re-implementation of the docker_pull_run_remove role that uses podman. It's slightly more comprehensive than the original role, but still very bare bones.

Closes #378

miabbott commented 6 years ago

There is an existing BZ or two about network access when using podman run that is going to bite us with this test.

I could add a separate tag that we could filter on or just wait until the BZs are fixed to merge this.

mike-nguyen commented 6 years ago

I'm okay with waiting for the BZs. Can you copy the BZs here so when they're fixed, I can just re-run and merge this?

miabbott commented 6 years ago

@mike-nguyen my understanding is that we need this https://github.com/containernetworking/plugins/pull/75 merged and then we need a new build of podman

mike-nguyen commented 6 years ago

Is this temporarily fixed with this: https://github.com/containers/libpod/pull/1431 ?

miabbott commented 6 years ago

It should be; but we still have to wait for builds to land across all the platforms.

miabbott commented 6 years ago

bot, retest this please

miabbott commented 6 years ago

bot, retest this please

miabbott commented 6 years ago

CentOS is still going to fail because the build of podman is too old to have the fix for --net=host, but everything else should be OK.

mike-nguyen commented 6 years ago

@miabbott I'm not too concerned about CentOS7. CAHC seems to be failing pulling from registry.access.redhat.com because it doesn't have a cert. If one is required can we put one in or just skip the r.a.rh.com test completely?

miabbott commented 6 years ago

Yeah, the root cause is here:

https://github.com/CentOS/sig-atomic-buildscripts/issues/329

I think there is still value in pulling from registry.access.redhat.com, so I'll further adjust the test to skip that registry on CAHC

miabbott commented 6 years ago

Just pushed a new commit with fixes. :arrow_up:

The CI checks are probably going to fail because OpenStack is bad and should feel bad.

mike-nguyen commented 6 years ago

Look, it worked!

mike-nguyen commented 6 years ago

LGTM!