search

projectatomic / atomic-host-tests

A collection of single-host tests for Atomic Host
GNU General Public License v3.0
18 stars 21 forks source link

rpm_ostree_livefs: detect which version of livefs cmd to use #450

Closed miabbott closed 5 years ago

miabbott commented 5 years ago

Distros that don't rev their version of rpm-ostree as frequently are missing the --i-like-danger switch when using rpm-ostree ex livefs.

This change detects the version of rpm-ostree and applies the switch appropriately.

mike-nguyen commented 5 years ago

Code looks good, unfortunately I think it will fail on RHEL AH because it probably doesn't behave the same was as the changes I made in #448. I haven't tested this theory. I can take a look after we merge this and add the code back in from #448 with the proper logic.

jlebon commented 5 years ago

IMO, I'm not sure it's worth spending too much time trying to get livefs tests to pass. It's known broken right now, its use is discouraged, and it's likely to change semantics in the future.

mike-nguyen commented 5 years ago

@miabbott I'm okay with merging this and then just letting it be a known failure in RHEL AH.

miabbott commented 5 years ago

Code looks good, unfortunately I think it will fail on RHEL AH because it probably doesn't behave the same was as the changes I made in #448.

The whole point of this change was to get it to work on RHELAH. :thinking:

miabbott commented 5 years ago

The whole point of this change was to get it to work on RHELAH. thinking

I'm pretty sure I tested this before submitting the PR, but it was late last night, so I could have been asleep.

Let me double-check my tests...

mike-nguyen commented 5 years ago

Just to re-iterate, I didn't test this theory :laughing:

miabbott commented 5 years ago

Just to re-iterate, I didn't test this theory laughing

It's been a rough morning already...my reading comprehension is suffering :roll_eyes:

miabbott commented 5 years ago

Or we just take the out from @jlebon and remove the livefs test completely...

mike-nguyen commented 5 years ago

@miabbott I'm fine with removing the test.

miabbott commented 5 years ago

YOLO...going to just remove it.

Closed in favor of #451

miabbott commented 5 years ago

FWIW, these changes worked on RHELAH ¯_(ツ)_/¯