search

projectatomic / atomic

Atomic Run Tool for installing/running/managing container images.
Other
524 stars 139 forks source link

overlay: reintroduce error when using 'rw' #1223

Closed giuseppe closed 6 years ago

giuseppe commented 6 years ago

the error message was mistakenly dropped with commit:

7179eab364831a8fdb1456e12dfe8085d2e04d67

Closes: https://github.com/projectatomic/atomic/issues/1222

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

giuseppe commented 6 years ago

/cc @TomasTomecek

rhatdan commented 6 years ago

LGTM

TomSweeneyRedHat commented 6 years ago

Change LGTM @giuseppe , but some of the tests aren't happy.

giuseppe commented 6 years ago

it is the usual flake test_storage.sh

rhatdan commented 6 years ago

bot, Retest this please.

We really should update the tests to run on fedora/27

TomasTomecek commented 6 years ago

It wasn't dropped mistakenly. I did mean to be able to mount a running container and change its content.

Though I agree this is fragile. We are running in constant issues with this. Sadly, +1 to disable such behavior.

We really should update the tests to run on fedora/27

I would even suggest F28 now.

giuseppe commented 6 years ago

@rh-atomic-bot r=rhatdan

rh-atomic-bot commented 6 years ago

:pushpin: Commit 8878a95 has been approved by rhatdan

rh-atomic-bot commented 6 years ago

:hourglass: Testing commit 8878a95 with merge 19801cb...

rh-atomic-bot commented 6 years ago

:broken_heart: Test failed - status-papr

giuseppe commented 6 years ago

@rh-atomic-bot r=rhatdan

rh-atomic-bot commented 6 years ago

:pushpin: Commit f32a6ce has been approved by rhatdan

rh-atomic-bot commented 6 years ago

:zap: Test exempted: pull fully rebased and already tested.

giuseppe commented 6 years ago

I had rebased it to stress the tests for Fedora 27