projectatomic / atomic

Atomic Run Tool for installing/running/managing container images.
Other
524 stars 139 forks source link

Should this `break` changed to `continue`? #1250

Closed QiWang19 closed 5 years ago

QiWang19 commented 5 years ago

https://github.com/projectatomic/atomic/blob/b507039153d03343d501a221270e7e8896cc3ece/Atomic/util.py#L733

If registries from current yaml_file is none, it should continue to next yaml_file. Current atomic trust show doesn't show sigstore from all of the yaml files under /etc/containers/registries.d

[qiwan@qiwan registries.d]$ ls -a
.  ..  default.yaml  docker.io-qiwanredhat.yaml
[qiwan@qiwan registries.d]$ cat docker.io-qiwanredhat.yaml 
docker:
  docker.io/qiwanredhat:
    sigstore: file:///var/lib/atomic/sigstore/

Should file:///var/lib/atomic/sigstore/ shows at the end of 3rd line?

$ atomic trust show
* (default)                         accept                               
docker.io                           accept                               
docker.io/qiwanredhat               accept                               
quay.io/crio/hello-world            reject                               
registry.access.redhat.com          signed security@redhat.com,security@redhat.com 
rhatdan commented 5 years ago

Yes I think so.