projectatomic / atomic

Atomic Run Tool for installing/running/managing container images.
Other
526 stars 140 forks source link

keep improving URI validation #823

Open miabbott opened 7 years ago

miabbott commented 7 years ago

While banging on #819, I found the following regarding ports:

$ sudo ./atomic trust add -t insecureAcceptAnything registry_domain:0
$ sudo ./atomic trust add -t insecureAcceptAnything registry_domain:0000
$ sudo ./atomic trust add -t insecureAcceptAnything registry_domain:10101010101

Also, this rule from the Docker Registry Spec could be implemented:

The total length of a repository name, including slashes, must be less the 256 characters.

First example is 256 characters, the second is 257 characters

$ sudo ./atomic trust add -t insecureAcceptAnything nndzszajylk7a4pv4j8mw63mu39s966y3ri1pxsfwtfyhrf5ssipbc0y7u4azeap2xi63sqhlmj7gb78tw7gqd27s3606j9oofji2d6aakj0pf52gesw2mu6b6aci
546op87ehpm02fgdui9wegqc34srgccu3yita1sp849ojf7gioy5xtf42ta4s0wdoc7u5yx60xvmphvm0nxmheozxjxyc453leqgyjyfe4w9a151yld8l8bqcp0k5ucr6qw
$ sudo ./atomic trust add -t insecureAcceptAnything nndzszajylk7a4pv4j8mw63mu39s966y3ri1pxsfwtfyhrf5ssipbc0y7u4azeap2xi63sqhlmj7gb78tw7gqd27s3606j9oofji2d6aakj0pf52gesw2mu6b6aci
546op87ehpm02fgdui9wegqc34srgccu3yita1sp849ojf7gioy5xtf42ta4s0wdoc7u5yx60xvmphvm0nxmheozxjxyc453leqgyjyfe4w9a151yld8l8bqcp0k5ucr6qw1
rhatdan commented 7 years ago

@aweiteka, @miabbott is trying to aggravate you, :^)

miabbott commented 7 years ago

I think with these additions, I'll be out of ideas to make @aweiteka miserable 😄