search

projectatomic / atomicapp

[UNMAINTAINED] This is the reference implementation of the Nulecule container application Specification: Atomic App
102 stars 71 forks source link

Refactor extracting #758

Closed cdrage closed 8 years ago

cdrage commented 8 years ago

This commit refactors extracting and separates the function into two calls. Extracting the files from the Docker container and extracting the Nulecule-specific files.

cc @dustymabe

cdrage commented 8 years ago

dotests

dustymabe commented 8 years ago

The diff would be a lot cleaner if you left the is_image_present(self, image) function at the bottom of the file.

dustymabe commented 8 years ago

Do you mind making the removal of the There has been some inconsistent behavior a separate commit? I image the functionality has stabilized now, would be nice to test and then state that in the commit msg.

cdrage commented 8 years ago

Much cleaner :) Thanks for reviewing @dustymabe

dustymabe commented 8 years ago

LGTM

cdrage commented 8 years ago

Thanks :) All tests pass (double-checked my side running unit + functional tests too)