projectatomic / atomicapp

[UNMAINTAINED] This is the reference implementation of the Nulecule container application Specification: Atomic App

102 stars 71 forks source link

collect only atomicapp tests #775

Closed concaf closed 8 years ago

concaf commented 8 years ago

In case of external libraries, their tests are not run, but only the ones in tests directory are run.

centos-ci commented 8 years ago

Can one of the admins verify this patch?

coveralls commented 8 years ago

Coverage remained the same at 56.649% when pulling d1a63025c30268271c1be3678908015acf5aab1e on containscafeine:fix_test_makefile into b2bf5caec27e32298009f154253499e515a22de1 on projectatomic:master.

cdrage commented 8 years ago

ok to test

cdrage commented 8 years ago

dotests

cdrage commented 8 years ago

@containscafeine this looks okay to me, but how are we going to test docker-py? shouldn't this actually be added though as part of the test suite?

unfortunatley since shipy isn't an external library yet, but part of the atomicapp code until it's added to rpm / deb, etc.

concaf commented 8 years ago

@cdrage, I have written functional tests for shipy, and those require access to the network and certain docker images, and are very slow to run, I don't think it makes sense for atomicapp to run those. I run those locally, and shipy used here is always even with shipy upstream.

cdrage commented 8 years ago

@containscafeine ah makes sense.

This LGTM then

cdrage commented 8 years ago

@kadel @dustymabe @rtnpro does this LGTY (look good to you)? :)