projectatomic / atomicapp

[UNMAINTAINED] This is the reference implementation of the Nulecule container application Specification: Atomic App

102 stars 71 forks source link

OpenShift to KubeShift #778

Closed cdrage closed 8 years ago

cdrage commented 8 years ago

An open PR to keep track of progress

TODO:

[x] Refactor OpenShift provider to use KubeShift
[x] Removes previous openshift.py tests
[x] Create new tests for KubeShift / OpenShift

dustymabe commented 8 years ago

can we have a better commit message than "refactor" ?

cdrage commented 8 years ago

@dustymabe Yeah, I was going to update this after the code changes :)

cdrage commented 8 years ago

Updated the PR with the OpenShift namespaces fix as per https://github.com/openshift/origin/issues/10334

cdrage commented 8 years ago

dotests

dustymabe commented 8 years ago

I think we are good to go.. merge away

coveralls commented 8 years ago

Coverage increased (+6.2%) to 64.302% when pulling 1a37ab82d5b173b5f3b74b8dc42ab22fbdcbf03c on cdrage:openshift-to-kubeshift into d1686c2f170ded68f459e8d1621c6a2e2ec5a393 on projectatomic:master.

dustymabe commented 8 years ago

maybe remove WIP from title first

cdrage commented 8 years ago

@dustymabe just going to run through a few last-minute tests and we'll be good to go :)