search

projectatomic / atomicapp

[UNMAINTAINED] This is the reference implementation of the Nulecule container application Specification: Atomic App
102 stars 71 forks source link

Add checking if resource is OpenShift specific to properly create OpenShift artifacts #802

Closed dymurray closed 7 years ago

dymurray commented 7 years ago

It appears that this file was copy pasted from the Kubernetes Kubeshift file and wasn't tested. Currently deploying an atomicapp which has a route as an artifact will fail since a route isn't listed as a Kubernetes resource. I tested this deploying an Etherpad atomicapp (https://github.com/fusor/nulecule-library/tree/master/etherpad-atomicapp) on Openshift with an added route artifact with success.

┆Issue is synchronized with this Asana task

centos-ci commented 7 years ago

Can one of the admins verify this patch?

centos-ci commented 7 years ago

Can one of the admins verify this patch?

centos-ci commented 7 years ago

Can one of the admins verify this patch?

centos-ci commented 7 years ago

Can one of the admins verify this patch?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.06%) to 65.128% when pulling c4a4d65199a33020b0792db1df4814b8f1096c93 on dymurray:ocp into 2b503eb59f30585eef565a13584bee7fe38c37ba on projectatomic:master.

cdrage commented 7 years ago

dotests

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.06%) to 65.128% when pulling fbe58c7e055bcaf4e9fe3a81dbbdab7556a8e790 on dymurray:ocp into 2b503eb59f30585eef565a13584bee7fe38c37ba on projectatomic:master.

cdrage commented 7 years ago

dotests

cdrage commented 7 years ago

Seems that this works correctly on all fronts! :) I'm going to go ahead and merge this.

cdrage commented 7 years ago

Thanks @dymurray

centos-ci commented 7 years ago

Can one of the admins verify this patch?

centos-ci commented 7 years ago

Can one of the admins verify this patch?

centos-ci commented 7 years ago

Can one of the admins verify this patch?

centos-ci commented 7 years ago

Can one of the admins verify this patch?