search

projectatomic / commissaire-http

Commissaire HTTP server
GNU General Public License v3.0
3 stars 7 forks source link

Use commissaire.util.config.import_plugin() #64

Closed mbarnes closed 7 years ago

mbarnes commented 7 years ago

Also, shorten the authentication plugin name in commissaire.conf and in test cases.

Requires: https://github.com/projectatomic/commissaire/pull/93

ashcrow commented 7 years ago 
ERROR: Failure: ImportError (cannot import name 'import_plugin')
mbarnes commented 7 years ago

ERROR: Failure: ImportError (cannot import name 'import_plugin')

That's expected until https://github.com/projectatomic/commissaire/pull/93 is merged.

mbarnes commented 7 years ago

@ashcrow Ping; this good to merge?

ashcrow commented 7 years ago

@mbarnes code is good. I believe the development docs need updating on how to create an Authentication plugin (http://commissaire.readthedocs.io/en/latest/authentication_devel.html).

mbarnes commented 7 years ago

@ashcrow Good catch. Submitted https://github.com/projectatomic/commissaire/pull/94 for the docs update.