search

projectatomic / commissaire-http

Commissaire HTTP server
GNU General Public License v3.0
3 stars 7 forks source link

handlers: Map 'METHOD_NOT_ALLOWED' error to HTTP status 405. #71

Closed mbarnes closed 7 years ago

mbarnes commented 7 years ago

Related to https://github.com/projectatomic/commissaire-http/issues/68

Initial use case: attempting to add an investigating, bootstrapping, or failed host to a cluster. More generally, for use when a request violates a semantic invariant.

Requires: https://github.com/projectatomic/commissaire/pull/110

ashcrow commented 7 years ago

bot, retest this please

ashcrow commented 7 years ago

@mbarnes looks like some tests are unhappy.

mbarnes commented 7 years ago

@ashcrow :arrow_up: I think the test failure is a side-effect of https://github.com/projectatomic/commissaire/commit/e0179985eaf0c775696806cad468f3cb84be70b3, but I can't explain why it was passing before; the test case was legitimately flawed.

ashcrow commented 7 years ago

@mbarnes odd. Good find though.