search

projectatomic / commissaire-http

Commissaire HTTP server
GNU General Public License v3.0
3 stars 7 forks source link

Python requests doesn't support UNIX sockets #78

Closed mbarnes closed 7 years ago

mbarnes commented 7 years ago

The secrets handler will forward incoming HTTP requests to the Custodia REST API over a UNIX socket, but the stock Python requests module doesn't support http+unix://.

This adds support, but it's not packaged for Fedora: https://github.com/msabramo/requests-unixsocket

The relevant code in adapters.py is fairly small, so I was thinking of just doing a copy+paste job into commissaire-http rather than grow a new dependency and shepherd this small module through the Fedora package review process.

Just filing this as an RFC.

mbarnes commented 7 years ago

Addressed in https://github.com/projectatomic/commissaire/issues/140.