search

projectatomic / commissaire-mvp

A lightweight REST interface for upgrading, restarting, and bootstrapping new hosts into an existing Container Management cluster.
http://commissaire.readthedocs.org/en/latest/
GNU General Public License v3.0
15 stars 9 forks source link

[merged] bdd: Travis now runs BDD tests. #124

Closed ashcrow closed 8 years ago

ashcrow commented 8 years ago

This change updates Travis to use Python2.7 and run the BDD tests.

The reason for the version bump is due to python-etcd using non-positional args in string formatting which was added in 2.7/3.1. I have an upstream PR that will hopefully be accepted (https://github.com/jplana/python-etcd/pull/176).

mbarnes commented 8 years ago

Interesting. I was working on this too a little yesterday trying to do it (unsuccessfully) with go get.

ashcrow commented 8 years ago

Yeah, it's a bit odd. I think following this pattern makes it a matter of figuring out the Travis runtime.

ashcrow commented 8 years ago

I'm going to switch testing over to 2.7 until something like https://github.com/jplana/python-etcd/pull/176 is in place.

mbarnes commented 8 years ago

I'd say Travis has pretty much already reviewed your patch and he's happy.

Pretty cool to see E2E tests in the logs now!

Looks GTG but I'll give @cooktheryan a chance to look before merging. Ah, sorry, I see now this is actually assigned to @cooktheryan.

mbarnes commented 8 years ago

@ashcrow said I can steal this... bwahahahah. :smiling_imp:

@rh-atomic-bot try

mbarnes commented 8 years ago

@rh-atomic-bot r+

rh-atomic-bot commented 8 years ago

:pushpin: Commit 4846e79 has been approved by mbarnes

mbarnes commented 8 years ago

@rh-atomic-bot r-

mbarnes commented 8 years ago

@rh-atomic-bot r+

rh-atomic-bot commented 8 years ago

:pushpin: Commit 4846e79 has been approved by mbarnes

cgwalters commented 8 years ago

@rh-atomic-bot retry

cgwalters commented 8 years ago

@rh-atomic-bot retry

cgwalters commented 8 years ago

@rh-atomic-bot try

mbarnes commented 8 years ago

@rh-atomic-bot: retry

rh-atomic-bot commented 8 years ago

:hourglass: Trying commit 4846e79 with merge 1847ed0...

rh-atomic-bot commented 8 years ago

:sunny: Test successful - travis State: approved=mbarnes try=True

rh-atomic-bot commented 8 years ago

:hourglass: Testing commit 4846e79 with merge 2a5ddd6...

rh-atomic-bot commented 8 years ago

:sunny: Test successful - travis Approved by: mbarnes Pushing 2a5ddd62aa4be6607bb9236051f76fd392458d34 to master...