projectatomic / commissaire-mvp

A lightweight REST interface for upgrading, restarting, and bootstrapping new hosts into an existing Container Management cluster.
http://commissaire.readthedocs.org/en/latest/
GNU General Public License v3.0
15 stars 9 forks source link

Cluster Types #166

Closed ashcrow closed 8 years ago

ashcrow commented 8 years ago
mbarnes commented 8 years ago

Code looks okay, but can you explain more why it's needed / how it's going to be used?

ashcrow commented 8 years ago

Sure. Many people using commissaire will use kubernetes or openshift but some may use commissaire without a container manager. Those folks will now have a way to keep their cluster from showing up as inactive. This will allow people to set up clusters that are just Atomic hosts or other things and take advantage of management parts of commissaire without the container parts.

ashcrow commented 8 years ago

https://trello.com/c/X2jeGJ9Q/311-3-multi-host-mgr-add-cluster-types

mbarnes commented 8 years ago

Ah, okay, makes sense.

@rh-atomic-bot r+

ashcrow commented 8 years ago

Hold please, WIP :smile:

mbarnes commented 8 years ago

Oh whoops, didn't see that.

ashcrow commented 8 years ago

@rh-atomic-bot r-

ashcrow commented 8 years ago

@mbarnes should be done with this shortly. Updating docs now. Also adding @cooktheryan to get him back in the groove of things.

mbarnes commented 8 years ago

@ashcrow Remove WIP label? See, you got me all paranoid now. :fearful:

ashcrow commented 8 years ago

@mbarnes haha will do once I push the doc changes :smile:

ashcrow commented 8 years ago

I'll follow on updates to ansible code in another PR to keep the layers separate.

ashcrow commented 8 years ago

:arrow_up:

mbarnes commented 8 years ago

LGTM with or without my suggestion. :+1:

mbarnes commented 8 years ago

@rh-atomic-bot r+

mbarnes commented 8 years ago

@rh-atomic-bot retry

ashcrow commented 8 years ago

I think something weird is going on with Travis and that might be making the bot flake. I noticed Travis is saying it can't find repositories.

mbarnes commented 8 years ago

Re-ran tests and merged manually.