Closed ashcrow closed 8 years ago
Code looks okay, but can you explain more why it's needed / how it's going to be used?
Sure. Many people using commissaire will use kubernetes or openshift but some may use commissaire without a container manager. Those folks will now have a way to keep their cluster from showing up as inactive. This will allow people to set up clusters that are just Atomic hosts or other things and take advantage of management parts of commissaire without the container parts.
Ah, okay, makes sense.
@rh-atomic-bot r+
Hold please, WIP :smile:
Oh whoops, didn't see that.
@rh-atomic-bot r-
@mbarnes should be done with this shortly. Updating docs now. Also adding @cooktheryan to get him back in the groove of things.
@ashcrow Remove WIP label? See, you got me all paranoid now. :fearful:
@mbarnes haha will do once I push the doc changes :smile:
I'll follow on updates to ansible code in another PR to keep the layers separate.
:arrow_up:
LGTM with or without my suggestion. :+1:
@rh-atomic-bot r+
@rh-atomic-bot retry
I think something weird is going on with Travis and that might be making the bot flake. I noticed Travis is saying it can't find repositories.
Re-ran tests and merged manually.