projectatomic / commissaire-mvp

A lightweight REST interface for upgrading, restarting, and bootstrapping new hosts into an existing Container Management cluster.
http://commissaire.readthedocs.org/en/latest/
GNU General Public License v3.0
15 stars 9 forks source link

Cluster status now honored at the transport layer. #168

Closed ashcrow closed 8 years ago

mbarnes commented 8 years ago

Looks good, just some nits.

ashcrow commented 8 years ago

Updated. One question added around the "global" nit.

ashcrow commented 8 years ago

:arrow_up:

mbarnes commented 8 years ago

@rh-atomic-bot r+

rh-atomic-bot commented 8 years ago

:pushpin: Commit d333574 has been approved by mbarnes

rh-atomic-bot commented 8 years ago

:hourglass: Testing commit d333574 with merge 4947df9...

rh-atomic-bot commented 8 years ago

:broken_heart: Test failed - travis

ashcrow commented 8 years ago

Restarting the test. Looks like a flake.

ashcrow commented 8 years ago

@rh-atomic-bot retry

rh-atomic-bot commented 8 years ago

:hourglass: Trying commit d333574 with merge 51ecf47...

rh-atomic-bot commented 8 years ago

:sunny: Test successful - travis State: approved=mbarnes try=True

rh-atomic-bot commented 8 years ago

:hourglass: Testing commit d333574 with merge 98eac53...

mbarnes commented 8 years ago

Homu seems stuck today so I merged it myself.