Fix nuisance error when terminating investigator thread.

projectatomic / commissaire-mvp

A lightweight REST interface for upgrading, restarting, and bootstrapping new hosts into an existing Container Management cluster.

http://commissaire.readthedocs.org/en/latest/

GNU General Public License v3.0

15 stars 9 forks source link

Fix nuisance error when terminating investigator thread. #189

Closed mbarnes closed 8 years ago

mbarnes commented 8 years ago

A special sentinel object is passed over a multiprocessing.Queue as a loop terminator for the InvestigatorPlugin's response thread. However the sentinel is pickled, so it's a different instance when popped off the queue and we were comparing object IDs.

Fixes https://github.com/projectatomic/commissaire/issues/188

ashcrow commented 8 years ago

Tests ran without issue.

LGTM!