Closed mbarnes closed 8 years ago
:umbrella: The latest upstream changes (presumably 1775790) made this pull request unmergeable. Please resolve the merge conflicts.
Rebased since merging the flanneld-server-client
branch.
I recommend updating the addresses in the tests to non routable addresses or example.org. Otherwise looks good.
:arrow_up: Good call. Fixed.
LGTM
Let's see if homu+travis is happy this morning ....
@rh-atomic-bot r+
:pushpin: Commit aafc4b6 has been approved by ashcrow
@rh-atomic-bot try
I'll rebase and push manually.
Merged.
A bit of polishing around store handler configuration. Docs will be a separate PR.
Changes:
host
/port
/protocol
keys with a singleserver_url
. I think this is less cumbersome for users and I see other projects using URLs in their config files.etcd.Client
arguments are assembled from theconfig
dictionary instead ofconfig
being passed through directly. I think this is safer.models
list makes accidental conflicts easier. Assigning a model to multiple store handlers now raises an error.