projectatomic / commissaire-mvp

A lightweight REST interface for upgrading, restarting, and bootstrapping new hosts into an existing Container Management cluster.
http://commissaire.readthedocs.org/en/latest/
GNU General Public License v3.0
15 stars 9 forks source link

Configuation format polishing #191

Closed mbarnes closed 8 years ago

mbarnes commented 8 years ago

A bit of polishing around store handler configuration. Docs will be a separate PR.

Changes:

rh-atomic-bot commented 8 years ago

:umbrella: The latest upstream changes (presumably 1775790) made this pull request unmergeable. Please resolve the merge conflicts.

mbarnes commented 8 years ago

Rebased since merging the flanneld-server-client branch.

ashcrow commented 8 years ago

I recommend updating the addresses in the tests to non routable addresses or example.org. Otherwise looks good.

mbarnes commented 8 years ago

:arrow_up: Good call. Fixed.

ashcrow commented 8 years ago

LGTM

ashcrow commented 8 years ago

Let's see if homu+travis is happy this morning ....

@rh-atomic-bot r+

rh-atomic-bot commented 8 years ago

:pushpin: Commit aafc4b6 has been approved by ashcrow

ashcrow commented 8 years ago

@rh-atomic-bot try

ashcrow commented 8 years ago

I'll rebase and push manually.

ashcrow commented 8 years ago

Merged.