search

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems
Apache License 2.0
153 stars 77 forks source link

Add versioning to docker-storage-setup. #192

Closed shishir-a412ed closed 7 years ago

shishir-a412ed commented 7 years ago

Signed-off-by: Shishir Mahajan shishir.mahajan@redhat.com

shishir-a412ed commented 7 years ago

ping @rhvgoyal

rh-atomic-bot commented 7 years ago

:umbrella: The latest upstream changes (presumably a24aeea) made this pull request unmergeable. Please resolve the merge conflicts.

rhvgoyal commented 7 years ago

@shishir-a412ed can you update this PR please.

shishir-a412ed commented 7 years ago

@rhvgoyal PTAL.

rhvgoyal commented 7 years ago

@shishir-a412ed So how about following.

MAJOR_VERSION=0 MINOR_VERSION=1 SUBLEVEL=0 EXTRA_VERSION=""

And final version will be VERSION=${MAJOR_VERSION}.${MINOR_VERSION}.${SUBLEVEL} [ -n "$EXTRA_VERSION" ] && VERSION="${VERSION}-$EXTRA_VERSION"

That is initially our version will look like.

0.1.0

Once we have something stable we will bump it to.

1.0.0

And after that during development, we can add extra version like -dev, or -rc1 etc.

1.0.0-dev 1.0.0-rc1

and then release a new version say 1.1.0

@rhatdan WDYT about above versioning scheme for docker-storage-setup.

rhatdan commented 7 years ago

I am fine with this. Not crazy about the -dev -rc1 stuff since this can cause rpm package versioning to get screwed up.

In Rawhide if we shipped these, the rc1 would take precedence over the -dev. Which might not be what you expect. We could just bounce the sublevel. But this is what docker does, and we end up truncating off the -dev field.

container-storage-setup-1.0.0-dev

contianer-storage-setup-1.0.0-rc1

rhvgoyal commented 7 years ago

I think -dev and -rc1 will be used for keeping track of status upstream and ideally rpms should not be packaging it.

Once we are ready to release something for packaging, then we can get rid of -dev and -rc1 and packagers can take that version and package it.

rhvgoyal commented 7 years ago

@shishir-a412ed can you update this PR. We probably need global variables as I describe in my comments.

rh-atomic-bot commented 7 years ago

:umbrella: The latest upstream changes (presumably abf5548) made this pull request unmergeable. Please resolve the merge conflicts.

rhatdan commented 7 years ago

We have gotten this from another pull request.