passing -n ftype=1 to mkfs.xfs for overlay2 docker storage driver support

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems

Apache License 2.0

153 stars 77 forks source link

passing -n ftype=1 to mkfs.xfs for overlay2 docker storage driver support #194

Open ravilr opened 7 years ago

ravilr commented 7 years ago

https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/7.2_Release_Notes/technology-preview-file_systems.html

says that xfs file systems must be created with the -n ftype=1 option enabled for use as an overlay. Also, dockerd seems to have a check for this as without this, certain docker operations might misbehave.

Can d-s-s create xfs with -n ftype=1 while creating fs for the container fs volume.

@rhatdan @rhvgoyal

rhvgoyal commented 7 years ago

@ravilr Though now latest xfsprogs has been modified so that by default mkfs.xfs uses ftype=1. But I guess it still makes sense to make use of it explicitly just in case user is using newer docker-storage-setup on older distribution.

rhvgoyal commented 7 years ago

@shishir-a412ed Would you like to create a PR for this.