Use findmnt option --target instead of --mountpoint

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems

Apache License 2.0

153 stars 77 forks source link

Use findmnt option --target instead of --mountpoint #209

Closed rhvgoyal closed 7 years ago

rhvgoyal commented 7 years ago

Old findmnt utility (on rhel/centos) does not support new option --mountpoint and tests fail there.

Signed-off-by: Vivek Goyal vgoyal@redhat.com

rhvgoyal commented 7 years ago

@rhatdan PTAL

rhatdan commented 7 years ago

LGTM

rhvgoyal commented 7 years ago

@rhatdan I think --target has some problems on rhel. It lists a mount point even if --target does not match. So we can't rely on --mountpoint or --target options in rhel.

rhvgoyal commented 7 years ago

For example,

[root@vm6-rhel7 ~]# findmnt --source /dev/mapper/rhel-home --target /home1 -n /home /dev/mapper/rhel-home xfs rw,relatime,seclabel,attr2,inode64,noquota

Above --target is home1 which does not match home still findmnt lists the mountpoint. In fedora that does not happen. So it is a bug in findmnt I think.

rhvgoyal commented 7 years ago

I guess that must have been the reason we did not use --target to begin with in original implementation.

rhatdan commented 7 years ago

LGTM

rhvgoyal commented 7 years ago

@rh-atomic-bot r+ 337ae8b

rh-atomic-bot commented 7 years ago

:hourglass: Testing commit 337ae8b with merge 3729c68...

rh-atomic-bot commented 7 years ago

:sunny: Test successful - status-redhatci Approved by: rhvgoyal Pushing 3729c68096446cd9c3c3f845d78f81e89677ce79 to master...