search

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems
Apache License 2.0
153 stars 77 forks source link

rpmlint does not like us using /usr/lib. #213

Closed rhatdan closed 7 years ago

rhatdan commented 7 years ago

Fedora review is finding some small issues. This pull request is an attempt to fix these.

cgwalters commented 7 years ago

I think rpmlint is happier with /usr/libexec/ FWIW. (But in any case that rpmlint check is really wrong, since it only matters for multilib, which we definitely don't care about for this)

rhatdan commented 7 years ago

@lsm5 PTAL

rhvgoyal commented 7 years ago

So what is rpmlint complaining about? dracut, systemd all store package shipped information in /usr/lib/

also libcss.sh is definitely a helper library.

rhatdan commented 7 years ago

I would say libcss.sh is a helper script rather then a library but that is semantics.

lsm5 commented 7 years ago

@rhatdan my comments have been addressed, I'll leave the rest to @rhvgoyal and you :)

lsm5 commented 7 years ago

ohh I forgot the thing about a LICENSE file, great if you can include it, but no problem if you don't want to

lsm5 commented 7 years ago

@rhatdan LICENSE should go in a separate line like so:

%license LICENSE

Rest looks good

rhatdan commented 7 years ago

I have moved the LICENSE to a separate pull request. Lets get this merged so we can approve the package and get it into Rawhide.

rhvgoyal commented 7 years ago

LGTM

rhvgoyal commented 7 years ago

@rh-atomic-bot r+ cee5aa7

rh-atomic-bot commented 7 years ago

:hourglass: Testing commit cee5aa7 with merge 618b150...

rh-atomic-bot commented 7 years ago

:sunny: Test successful - status-redhatci Approved by: rhvgoyal Pushing 618b1509c631ee4b4d2a57cb97015a641d475ace to master...

rhatdan commented 7 years ago

@lsm5 Can we get the bugzilla approved now, and I will add LICENSE early next week if/when we get the ACKS?